-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bybit: Fix WS ticker processing #1538
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
- Coverage 36.28% 36.23% -0.06%
==========================================
Files 419 419
Lines 183133 182999 -134
==========================================
- Hits 66458 66308 -150
- Misses 108578 108623 +45
+ Partials 8097 8068 -29
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements! I found an issue earlier than this change though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, it all looks swell. Just a linter fix regarding 32bit
2639b11
to
64977cc
Compare
94053ac
to
94106b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff Tack!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! 😎
[DEBUG] | WEBSOCKET | 03/07/2024 15:37:02 | Bybit websocket connection: message received: {"topic":"orderbook.50.DOGEUSDT","ts":1719985022048,"type":"delta","data":{"s":"DOGEUSDT","b":[["0.12165","36664.7"]],"a":[],"u":7731147,"seq":43399847369},"cts":1719985022043}
[ERROR] | WEBSOCKET | 03/07/2024 15:37:02 | could not sync new data for Bybit DOG EUSDT spot Orderbook
[DEBUG] | WEBSOCKET | 03/07/2024 15:37:02 | Bybit websocket connection: message received: {"topic":"tickers.DOGEUSDT","ts":1719985022050,"type":"snapshot","cs":43399844543,"data":{"symbol":"DOGEUSDT","lastPrice":"0.1218","highPrice24h":"0.12555","lowPrice24h":"0.1209","prevPrice24h":"0.12393","volume24h":"101856596.5","turnover24h":"12578442.728828","price24hPcnt":"-0.0172","usdIndexPrice":"0.121624"}}
[INFO] | SYNC | 03/07/2024 15:37:02 | Bybit websocket DOGE-USDT SPOT TICKER: Last 0.12180000 Ask 0.00000000 Bid 0.00000000 High 0.12555000 Low 0.12090000 Volume 101856596.50000000
22179fa
to
c954d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR + in depth testing coverage!
Type of change
How has this been tested